I think it depends on what you need from therapy. Some people really just need someone to talk to, so a sit-and-listen kinda therapist works best with them. Other people need to build strong and close rapport with their therapist. Others don't care about being friendly or venting, and only want to hear solutions and advice.
In general though a good therapist gets along with you and is trustworthy. They also have clear boundaries and don't behave inappropriately with you. Anyone who insults you, says you're hopeless, looks clearly distracted with their phone or computer during session, etc. is unfit to practice and is probably violating some ethics rules. Similarly, someone who is overly attached to you or allows you to invade their privacy is doing you no favors and can be just as bad as an overly distant therapist.
Personally I did much better with my school counselor who did CBT with me. She gave me advice, alternatives, solutions, etc. and it wasn't like I was just talking at her. I still try to use the stuff she taught me in my life. My other therapist was very sweet, but all she would do was stare at me and listen. I wasn't making any progress and I felt shittier than usual after her sessions. I guess some people really benefit from just venting, but I do enough of that already, so I prefer the structure of CBT.